987212 - Invisible gif (visibility: hidden) activates the refresh driver

Status: RESOLVED WORKSFORME

(Core :: CSS Parsing and Computation, defect)

Description

[Roberto Agostino Vitillo (:rvitillo)]

Idling on the vube homepage seems to consume significantly more energy than on IE and Chrome.

Comment 1

[Roberto Agostino Vitillo (:rvitillo)]

Attachment: Testcase 1

The invisible gif in the testcase activates the refresh driver.

Comment 2

[Mats Palmgren (inactive)]

Attachment: wip

Calling RegisterImageRequestIfAnimated/DeregisterImageRequests based on
the 'visibility' value seems to work.  Timothy, is this the right way
to go?

https://tbpl.mozilla.org/?tree=Try&rev=f0f11f8c00dd

Comment 3

[Timothy Nikkel (:tnikkel)]

Comment on attachment 8397402 [details] [diff] [review]
wip

This approach seems reasonable to me.

Comment 4

[Daniel Holbert [:dholbert]]

Cleopatra (the profiler UI) hits this as well. It has a throbber image which gets displayed briefly, but continues to trigger the refresh driver since it's only hidden with visibility:hidden. (See bug 1004541.)

Comment 5

[Nicholas Nethercote [inactive]]

Mats: is this still relevant? Thanks.

Comment 6

[Mats Palmgren (inactive)]

Yeah, I think so.  I still see calls to nsRefreshDriver::AddImageRequest in a debugger
for the image in the testcase.  It looks like most of the patch would still apply
(I haven't tried applying it though).

Unfortunately, I don't have time to work on this for a while...
Perhaps seth@ or tn@ can take it from here?

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Emilio, the testcase as attached doesn't reproduce a high load for me. In the case that this got fixed in the meantime we should be able to close this bug.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

I don't see anything off-hand that would've fixed this bug, but you're right that it seems fixed. Would be great to bisect it...

Comment 9

[Timothy Nikkel (:tnikkel)]

Andrew landed some changes to stop updating animated images if the previous frame was never requested (ie painted) a while back (a few years?).

Comment 10

[Timothy Nikkel (:tnikkel)]

That would be bug 1454149.

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Ah, sweet then :)